search

surrealdb / surrealist

Surrealist is the ultimate way to visually manage your SurrealDB database
https://surrealist.app/
MIT License
1.04k stars 74 forks source link

BUG - App crashes when moving table in designer view #216

Closed Jacob26502 closed 3 months ago

Jacob26502 commented 3 months ago

Describe the bug The App & Website crash when letting go of a table in the explorer while still moving the mouse. React minified Error 185: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://surrealist.app/designer
  2. Load the "Surreal Deal" demo dataset, alternatively create an empty table
  3. Go to designer view, try and move any table with your mouse, but let go of the table while the mouse pointer is in motion
  4. See error image

Expected behavior The app should not crash when moving a table in the explorer view.

Environment: Happens on both a fresh copy of the website and the desktop Tauri version

Platform: Web Navigator: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36 Version: 2.0.2 Flags: featureFlags: false, models_view: true, apidocs_view: true, themes: false, newsfeed: true

OR

Platform: Desktop OS: Windows_NT Architecture: x86_64 WebView: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36 Edg/123.0.0.0 Version: 2.0.2 Flags: featureFlags: false, models_view: true, apidocs_view: true, themes: false, newsfeed: true

macjuul commented 3 months ago

I'm currently unable to reproduce this issue myself on MacOS

Icaruk commented 3 months ago

Dragging fast crashes.

Platform: Desktop
OS: Windows_NT
Architecture: x86_64
WebView: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36 Edg/124.0.0.0
Version: 2.0.2
Flags: featureFlags: false, models_view: true, apidocs_view: true, themes: false, newsfeed: true

image

macjuul commented 3 months ago

This issue should be fixed in the next patch release, however if you do still run into this error feel free to re-open the issue