surrealdb / surrealist

Surrealist is the ultimate way to visually manage your SurrealDB database
https://surrealist.app/
MIT License
1.03k stars 73 forks source link

Redo shortcut missing #324

Closed LucyEgan closed 6 days ago

LucyEgan commented 1 month ago

Describe the bug Currently undo via Ctrl + Z and redo via Ctrl + Y are available, but redo via Ctrl + Shift + Z is missing

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'query editor'
  2. Press 1 (1), [BACKSPACE], 2 (2), [BACKSPACE], 3 (3)
  3. Press Ctrl + Z (), Ctrl + Z (1)
  4. Press Ctrl + Shift + Z (Should be 2)

Expected behaviour Pressing Ctrl + Shift + Z should be the same as Ctrl + Y

Environment: Platform: Desktop OS: Windows_NT Architecture: x86_64 WebView: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 Edg/125.0.0.0 Version: 2.0.0 Flags: featureFlags: true, models_view: true, apidocs_view: true, themes: true, newsfeed: true

macjuul commented 1 week ago

This should be working correctly in the latest release

LucyEgan commented 1 week ago

@macjuul Is "latest release" referring to a upcoming version as this is still the case in 2.1.2?

Running version 2.1.2 shortcut Ctrl + Shift + Z does nothing.

Platform: Desktop
OS: windows
Architecture: x86_64
WebView: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0
Version: 2.1.2
Flags: feature_flags: true, models_view: true, apidocs_view: true, themes: true, newsfeed: true, database_version_check: false, highlight_tool: true, surreal_compat: v2, changelog: auto
macjuul commented 1 week ago

Strange, it's working fine for me on 2.1.2 on both the desktop app (MacOS) and web

LucyEgan commented 1 week ago

I'll have a check on osx web and windows web when I get a moment. Is the shortcut bound to meta + shift + z? Cus that would be correct for osx and not Windows or are both bound?

Sandros94 commented 1 week ago

Strange, it's working fine for me on 2.1.2 on both the desktop app (MacOS) and web

Not on windows (or at least for me), both desktop and web

LucyEgan commented 6 days ago

Can confirm it worked fine on OSX but not windows

macjuul commented 6 days ago

Thanks for checking! I have implemented a fix which will be included in the next release