search

surrsurus / edgequest

Edgequest Season Two
Mozilla Public License 2.0
8 stars 1 forks source link

Fix water rendering issue for entity backgrounds #37

Closed surrsurus closed 6 years ago

surrsurus commented 6 years ago

Water renders improperly as a background for creatures. Issue revolves around how water changes color and that color isn't updated for entity backgrounds on that tile.

sudo-prime commented 6 years ago

Discussed earlier today - the final verdict as for the solution to this bug was to:

  1. Not allow the renderer to modify the world. The world should be read-only to the renderer.
  2. Instead of allowing the renderer to perform an action on the water tile's color, creating a "render color" that's separate from what's actually saved in the world, the world should handle updating a tile's "real color".
  3. Avoid runaway color processing by not performing an operation on the color - rather, select an acceptable blue color from a list of colors.