surveydown-dev / surveydown

Markdown-Based Surveys Using R, Quarto, and Shiny
https://pkg.surveydown.org/
Other
65 stars 10 forks source link

Add ... argument to sd_update_surveydown() #94

Closed jmgirard closed 2 months ago

jmgirard commented 2 months ago

Currently, sd_update_surveydown() calls sd_update_extension() but there is no opportunity to change the latter's path argument when doing so. Adding ... to the former and passing it to the latter addresses this.

jhelvy commented 2 months ago

I appreciate you catching this! But I am also sorry to say that in the next iteration that we are soon to release will no longer need the extension. Nonetheless, I will merge your patch here as I certainly appreciate contributions people are making to this project! We are hoping to release the next major change very soon, possibly tomorrow (complete with blog post, etc...lots of breaking changes coming).

jhelvy commented 2 months ago

Just released the new version (see this discussion)