search

surveyjs / custom-widgets

The collection of custom widgets for SurveyJS: Survey Library and Survey Creator :package:
https://surveyjs.io
MIT License
79 stars 78 forks source link

sortable list text changing not working on typing or on blur #204

Closed WoodenPC closed 4 years ago

WoodenPC commented 4 years ago

Are you requesting a feature, reporting a bug or ask a question?

bug

What is the current behavior?

text changing after adding or removing item in sortable list

What is the expected behavior?

text changing on typing or on blur

How would you reproduce the current behavior (if this is a bug)?

https://surveyjs.io/Examples/Builder/?id=customwidgets select sortable list widget, open choices property, change text in any item -> text is not updating on view

Provide the test code and the tested page URL (if applicable)

Tested page URL: https://surveyjs.io/Examples/Builder/?id=customwidgets

Specify your

tsv2013 commented 4 years ago

Thank you for the report. We'll take a look.

andrewtelnov commented 4 years ago

@WoodenPC I have fixed the issue. We will include the fix in v1.7.21 that we are going to release today/tomorrow.

Thank you, Andrew

WoodenPC commented 4 years ago

Thank you very much! @andrewtelnov please look at the other props too, it seems that update of "empty text" prop also not working. Idk, maybe this problem can be related to other props in sortablelist widget? image

andrewtelnov commented 4 years ago

@WoodenPC I have fixed it as well and move properties into "general" tab.

Thank you, Andrew

WoodenPC commented 4 years ago

@andrewtelnov Are u sure "empty text" is fixed ? I checked it again and seems it still broken

andrewtelnov commented 4 years ago

@WoodenPC It is fixed in v1.7.24 that we are not released yet. You did not create a new issue, that is why there is a misunderstanding. Here is the commit.

Thank you, Andrew