surveyjs / custom-widgets

The collection of custom widgets for SurveyJS: Survey Library and Survey Creator :package:
https://surveyjs.io
MIT License
79 stars 78 forks source link

IE11 "multiple definitions strict mode" bug #212

Closed xxxKOTxxx closed 4 years ago

xxxKOTxxx commented 4 years ago

I got IE11 error "multiple definitions strict mode".

Inspection show that it caused by next code:

e.JsonObject.metaData.addProperty("sortablelist",{name:"emptyText",category:"general",default:"Move items here.",category:"general"})

I think problem is in duplicated category property. I found at least 3 duplications.

Can You fix it?

tsv2013 commented 4 years ago

How can we reproduce the issue?

xxxKOTxxx commented 4 years ago

How can we reproduce the issue?

In my case it's react app with "use strict"; and IE 11.0.9600.18860

I'm using this VM

In repo src/sortablejs.js we can find on line 35 next code: Survey.JsonObject.metaData.addProperty("sortablelist", { name: "emptyText", category: "general", default: "Move items here.", category: "general", }); Survey.JsonObject.metaData.addProperty("sortablelist", { name: "useDefaultTheme:switch", category: "general", default: true, category: "general", }); Survey.JsonObject.metaData.addProperty("sortablelist", { name: "maxAnswersCount:number", category: "general", default: -1, category: "general", });

In any case: what sense in category: "general", duplication? It's an issue I think.

tsv2013 commented 4 years ago

Thanks, I see now. I should be more scrupulous. It's a bug indeed. We'll fix it.

tsv2013 commented 4 years ago

Fix will be available in 1.8.2