search

surveyjs / custom-widgets

The collection of custom widgets for SurveyJS: Survey Library and Survey Creator :package:
https://surveyjs.io
MIT License
79 stars 78 forks source link

Update jquery-ui-datepicker.js #314

Closed AndOne1974 closed 1 year ago

AndOne1974 commented 2 years ago

fix $ to jQuery

AndOne1974 commented 2 years ago

$j = jQuery.noConflict();

$ is undefined after that, only jQuery works … all jQuery plugins should bind directly to jQuery and not to $

Von: tsv2013 @.*** Gesendet: Donnerstag, 10. November 2022 09:58 An: surveyjs/custom-widgets Cc: AndOne1974; Author Betreff: Re: [surveyjs/custom-widgets] Update jquery-ui-datepicker.js (PR #314)

@tsv2013 requested changes on this pull request.

What's the issue with the $ sign?

— Reply to this email directly, view it on GitHub https://github.com/surveyjs/custom-widgets/pull/314#pullrequestreview-1175306893 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL7UBC5E543JZK6M6KYMSDWHS2K7ANCNFSM6AAAAAARRAZHLQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AAL7UBA5UVSWHX6IEIM42A3WHS2K7A5CNFSM6AAAAAARRAZHLSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSGBXBI2.gif Message ID: @. @.> >

AndOne1974 commented 1 year ago

Any update on my MR?

tsv2013 commented 1 year ago

Sorry for missing your answer. I've checked jQuery documentation and hope finally get the case you're talking about. I think we can merge your PRs.