search

surveyjs / survey-creator

Scalable open-source survey software to generate dynamic JSON-driven forms within your JavaScript application. The form builder features a drag-and-drop UI, CSS Theme Editor, and GUI for conditional logic and form branching.
https://surveyjs.io/open-source
Other
923 stars 377 forks source link

Bootstrap 4 on Survey Creator #1185

Open darwin-focus opened 3 years ago

darwin-focus commented 3 years ago

Hello,

Sorry if I have missed something. If I have please let me know what and I will provide the info if I can.

Are you requesting a feature, reporting a bug or ask a question?

All of the above?

What is the current behavior?

When trying to do: npm install I get the following error.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: darwin@undefined
npm ERR! Found: bootstrap@4.6.0
npm ERR! node_modules/bootstrap
npm ERR!   bootstrap@"^4.6.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer bootstrap@"^3.3.6" from survey-creator@1.8.46
npm ERR! node_modules/survey-creator
npm ERR!   survey-creator@"^1.8.29" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

It does install when I add the --legacy-peer-deps however I would like to not have to install with legacy stuff.

What is the expected behavior?

To do the npm install without having to pull legacy stuff.

How would you reproduce the current behavior (if this is a bug)?

Install

node -v       
v16.0.0

npm -v        
7.10.0

package.json:

"dependencies": {
    "bootstrap": "^4.6.0",
    "survey-creator": "^1.8.29",
    "survey-vue": "^1.8.29",
}

try to run npm install

Additional info:

I have tried by pulling the CDN but that is not really a good solution, and didn't work either, for our project.

Questions:

  1. Am I maybe doing something wrong, or have I missed something during install and setup?
  2. If not, would it be possible to make the survey creator use Bootstrap 4 instead of 3?
  3. Also I have seen that they are making Bootstrap 5. Do you have plans to switch to that as well?

Thank you.

tsv2013 commented 3 years ago

Here is the live plunker sample with BS 4.0.0 - https://plnkr.co/edit/5vCwd6iDop9k9DBg

I've tried to update BS to 4.6.0 - but it has same issues.

PavlosIsaris commented 2 years ago

Is there any update on this?