surveyjs / survey-library

Free JavaScript form builder library with integration for React, Angular, Vue, jQuery, and Knockout.
https://surveyjs.io/form-library
MIT License
4.13k stars 805 forks source link

Performance optimization with react when css object doesn't change #1934

Open als753 opened 4 years ago

als753 commented 4 years ago

Are you requesting a feature, reporting a bug or asking a question?

Feature/Performance improvement

What is the current behavior?

I am re-loading data into a panel and although that data is only relevant to one question, I am seeing all questions reload. When I inspect this in the react profiling tool, I see that the component thinks the css prop has changed, because it is not doing a deep comparison.

What is the expected behavior?

I would like to improve performance by checking that the css object has not actually changed through a deep comparison on shouldcomponentupdate.

Specify your

tsv2013 commented 4 years ago

Thank you for the suggestion. We'll add it in our TODO list