search

surveysparrow / surveysparrow-flutter-sdk

SurveySparrow Flutter SDK enables you to collect feedback from your mobile app. Embed the Classic surveys in your Flutter application seamlessly with few lines of code.
MIT License
2 stars 4 forks source link

if(mounted) added for setState() #4

Closed samvit-refyne closed 4 months ago

samvit-refyne commented 1 year ago

mounted check added before calling setState()

Issue: #5

Kindly review @sachin-kumar56 @hemanath-ss

hemanath-ss commented 1 year ago

@sachin-kumar56 , Can you review this?

samvit-refyne commented 1 year ago

@sachin-kumar56 @hemanath-ss Any update on this ?

sachin-kumar56 commented 1 year ago

@samvit-refyne @hemanath-ss the pr looks good, checking all test cases and will approve once that is done.

samvit-refyne commented 1 year ago

Hi @sachin-kumar56 ,

Just wanted to check if you are planning to release a new version including this fix, if the process takes time, will use the forked one so that we can reduced the noise from our crashlytics dashboard till it's merged and released.

Thanks