table component ui improvement

surveysparrow / twigs

Themeable, Customisable and Fully Accessible React Component Library from SurveySparrow

https://twigs.surveysparrow.com/

MIT License

20 stars 10 forks source link

table component ui improvement #70

Closed meenakshi-ss closed 2 months ago

meenakshi-ss commented 4 months ago

Removed Hover effect on Table Header and changed the bg
Added only borderBottom
Updated hover and active colors for Tr
Added pointer cursor type for row elements
Added docs for Table component

justin-ss commented 4 months ago

@meenakshi-ss we don't have a documentation on Table Component. It would be nice to release that also. @akzhysparrow please coordinate on what all has to be documented

akzhysparrow commented 4 months ago

@justin-ss There is a an issue with table in docusaurus, the default styling for tables in docusaurus is interfering with the styles that we are applying and the output is incorrect. We will either have to force reset all the styles for docs alone or we will have to embed it in an iframe. I tried using shadow DOM but in that case stitches styles were also not getting applied.

justin-ss commented 4 months ago

@justin-ss There is a an issue with table in docusaurus, the default styling for tables in docusaurus is interfering with the styles that we are applying and the output is incorrect. We will either have to force reset all the styles for docs alone or we will have to embed it in an iframe. I tried using shadow DOM but in that case stitches styles were also not getting applied.

Is this a problem in Live Editor also?

meenakshi-ss commented 4 months ago

@justin-ss There is a an issue with table in docusaurus, the default styling for tables in docusaurus is interfering with the styles that we are applying and the output is incorrect. We will either have to force reset all the styles for docs alone or we will have to embed it in an iframe. I tried using shadow DOM but in that case stitches styles were also not getting applied.

Is this a problem in Live Editor also?

@justin-ss , the issue is happening in live editor and its preview only, and in storybook it is working fine.

akzhysparrow commented 4 months ago

We could make a sandbox and link it there instead of live preview until the playground can support custom examples @justin-ss

maneeshp97 commented 1 week ago

@all-contributors please add @meenakshi-ss for code, bug

allcontributors[bot] commented 1 week ago

@maneeshp97

I've put up a pull request to add @meenakshi-ss! :tada: