search

surveywp / kk-star-ratings

kk Star Ratings wordpress plugin
https://wordpress.org/plugins/kk-star-ratings
Other
119 stars 44 forks source link

replaced br clear with CSS clearfix #11

Closed ghost closed 7 years ago

ghost commented 8 years ago

The clear attribute on the br element is obsolete. Replaced with CSS alternative.

ghost commented 7 years ago

Fixed the warning notice for PHP 7

kamalkhan commented 7 years ago

Kindly clone the master branch and create a new pull request for the php 7 warning so I may merge the fix.

ghost commented 7 years ago

I have, that's what this is... it's added this automatically to the existing pull request that I made last year, I don't think you've accepted that. Surely, you can just merge this entire request?

kamalkhan commented 7 years ago

I didnt merge the previous commit as I dont think adding a clearfix class will change anything because there is no clearfix css rule in the stylesheet. I am closing this PR so you may send a new pull request as I had to fix the indentation for the index.php file in the meantime.