surveywp / kk-star-ratings

kk Star Ratings wordpress plugin
https://wordpress.org/plugins/kk-star-ratings
Other
119 stars 44 forks source link

Correct schema.org for AggregateRating legend #23

Closed manooweb closed 7 years ago

manooweb commented 7 years ago

Hi,

I use kk start ratings plugin on a website and snippet were not displayed in google search results. When I corrected grs_legend function with new schema.org for AggregateRating schema, snippet is now displayed again.

https://schema.org/AggregateRating

Note : for working kk star ratings code must be embeded in another schema as Article ou Blog which aggregateRating is a property

https://schema.org/Article https://schema.org/Blog

Best Regards Emmanuel

manooweb commented 7 years ago

OK. I don't know why all the index file is changed because I changed only some part of grs_legend function.

I will see if I can do another PR.

Thanks

kamalkhan commented 7 years ago

Still the same issue, It says 741 additions and 743 deletions :(

I will see how this can be cleaned up. Maybe adding a .editorconfig file.

kamalkhan commented 7 years ago

I have added a .editorconfig file so that the encoding is correct. Kindly fork the master branch into a non master branch, make the changes and send a new PR so I may merge the changes.

manooweb commented 7 years ago

I'm still looking for why.

I use UTF-8 and PSR-2 formatting and netbeans.

I did some other PR without problem.

So, I delete autoformatting code, the diff with git is ok but when I push on githug it is not ok for PR :-/

I forked again your repository for testing and I will do another PR when it will ok.

manooweb commented 7 years ago

I saw .editorconfig file. You configured LF for line feed but index.php file is with CRLF linefeed.

I will do a new branch for testing and will do a PR on it.

Thanks

manooweb commented 7 years ago

Hi,

I am closing this PR because I did another one with correct code fomatting.

Best regards Emmanuel

kamalkhan commented 7 years ago

Merged using https://github.com/kamalkhan/kk-star-ratings/pull/24