search

surveywp / kk-star-ratings

kk Star Ratings wordpress plugin
https://wordpress.org/plugins/kk-star-ratings
Other
118 stars 44 forks source link

render javascript by wp_head instead #48

Closed saekoew closed 1 year ago

saekoew commented 6 years ago

function enqueue_js in bhittani-framework/plugin.php There is code to render javascript. Sometimes it writes javascript before html tag.

kamalkhan commented 6 years ago

I am currently working on something else and in the process of recreating the plugin. So for now i would recommend you to modify the code however you see fit. I am also open to pull requests.

stodorovic commented 5 years ago

This code could break sitemaps/feeds in some cases. I just created #48 which uses function wp_add_inline_script if it exists ( WP>=4.5 ). So, it seems as correct solution because a lot of users have installed newer WP. Older WP version will use old code. @saekoew Could you test this PR? I tried some basic test and JS code is on proper place.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.