surveywp / kk-star-ratings

kk Star Ratings wordpress plugin
https://wordpress.org/plugins/kk-star-ratings
Other
118 stars 44 forks source link

Include Option for customised suffix. #68

Closed Nio-av closed 5 years ago

Nio-av commented 5 years ago

Problem: plural of votes is not always a word ending with 's'.

e.g. in english: 1 vote, 15 votes

e.g. in german: 1 Bewertung, 15 Bertungen

so, the current plugin is not compatable with all languages.

Until now, here is the fix ;)

  1. Include Option in Backend to define an customised suffix.
  2. include logic to use this customised suffix.
kamalkhan commented 5 years ago

Thank you.

Nio-av commented 5 years ago

Will there be an update of the PlugIn on WordPress.org in the PlugIn - Libary, @kamalkhan ?

kamalkhan commented 5 years ago

Already updated.

TheSmartDude commented 5 years ago

The solution doesn't work. It shows the placeholder "[s]" instead of the suffix i.e. "s" or "en". So we see vote[s] instead of votes or Bewertung[s] instead of Bewertungen. Please correct it.

Nio-av commented 5 years ago

Hi @TheSmartDude ,

There has been an other Update:

https://github.com/Nio-av/kk-star-ratings/commit/eef8b9f7eb4a85e57201524cc299fdc3436de3a5

Please try [suffix] instead. The string [s] has been a little bit confusing for some of our team members.

Does that help?

TheSmartDude commented 5 years ago

Hi @Nio-av, yeahh that helped! :) Their should be an advice in the plugin or (the better way) change the placeholder to the correct one by default. :)

Nio-av commented 5 years ago

Hi @TheSmartDude,

grafik

This is the current Version of the PlugIn. What sort of advice do you mean? The old shortcode [s] has been online on github just for a few days - an automatic replacement of the old shortcode might couse more troubles than it would fix.