Closed vjancik closed 8 years ago
Because the activateLaneEdit handler is attached here, instead of here as:
activateLaneEdit
<Editable className="lane-name" editing={lane.editing} value={lane.name} onValueClick={this.activateLaneEdit} onEdit={this.editName} />
There is an error here: Uncaught TypeError: _this.props.onValueClick is not a function
Uncaught TypeError: _this.props.onValueClick is not a function
Lane name editing still works because the changes go through the store.
onValueClick needs to become optional as the editing state is handled differently there.
onValueClick
Good catch! Thanks.
There's a check in place for this case now. Thanks.
Because the
activateLaneEdit
handler is attached here, instead of here as:There is an error here:
Uncaught TypeError: _this.props.onValueClick is not a function
Lane name editing still works because the changes go through the store.