search

survivejs / react-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/react/introduction/
2.02k stars 366 forks source link

[Suggestion] Linting problem #398

Closed vjancik closed 8 years ago

vjancik commented 8 years ago

There's an issue with ESLint: https://github.com/eslint/eslint/issues/6001 https://github.com/eslint/eslint/issues/5679

and using this causes the linter to run for over 10 seconds (if your node_modules are populated, on OS X for sure, not sure what other platforms) . I solved it by changing it to: "lint": "eslint ./app --ext .js --ext .jsx --cache",

You may consider adding webpack.config.js too to replicate original behavior.

bebraw commented 8 years ago

Thanks. This chapter is going to the webpack book really soon. I've added --cache to the dev version there.

I'll close this once that has been published.

vjancik commented 8 years ago

The problem is in the dot . not in --cache. Replace . with ./app. Sorry if I just said the obvious, from your response it seemed like you missed the point.

bebraw commented 8 years ago

Missed the point, yeah. Thanks for highlighting that.

bebraw commented 8 years ago

I'm tracking https://github.com/eslint/eslint/issues/5679 . If they can resolve the issue, perhaps the book doesn't need an update for this after all.

bebraw commented 8 years ago

Solved at dev. Given the release is so near, closing.

bebraw commented 8 years ago

@vjancik Looks like they did a fix. See https://github.com/eslint/eslint/issues/5679 . That could help. 👍