search

survivejs / react-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/react/introduction/
2.02k stars 366 forks source link

[I 6.5 - Tracking Note editing State] - Error on click to finish editing #439

Closed JESii closed 2 years ago

JESii commented 7 years ago

At the end of this section, you say "If you click a Note twice to confirm the edit, you should see an Uncaught Invariant Violation error..."

Instead, when I click the Note once, I get this error: image

Commit with the code is here

bebraw commented 7 years ago

Yeah, looks like the error changed in React 15. Good point.

JESii commented 7 years ago

At some point, I think you're gonna have to pick a release and just stick with it -- else you could go nuts trying to keep up with this.

With webpack and package.json, couldn't you just 'freeze' things in a known state and have a reliable target?

bebraw commented 7 years ago

A big rewrite is needed anyhow so it's good you open these issues. 👍

JESii commented 7 years ago

OK; I'll call 'em as I sees 'em :=)