search

survivejs / react-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/react/introduction/
2.02k stars 366 forks source link

Removed redundant spread operator #446

Closed skarlinski closed 6 years ago

skarlinski commented 6 years ago

Object.assign returns an object anyways. Spread operator there adds confusion.

bebraw commented 6 years ago

Great. Thanks.

I think I should rewrite the chapter to use the new context API and finally drop Alt. That will clean the implementation as well.

skarlinski commented 6 years ago

I think that would be great. I found this book to be the first one that works for me for React, but currently really trying not to drop out because I can't figure out this chapter. main problem is that there is no other source of information regarding connectors and providers, and the alt docs are no goid. Still appreciate the book, it was amazing this far.

On Tue, Mar 13, 2018, 5:33 PM Juho Vepsäläinen notifications@github.com wrote:

Great. Thanks.

I think I should rewrite the chapter to use the new context API and finally drop Alt. That will clean the implementation as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/survivejs/react-book/pull/446#issuecomment-372708042, or mute the thread https://github.com/notifications/unsubscribe-auth/AJH9YyPSsvHivqAutx1coj6fcUMvaYtyks5td-bZgaJpZM4SnGQp .