search

survivejs / site

survivejs.com
https://survivejs.com/
Other
68 stars 22 forks source link

Non-unique IDs on the homepage #102

Open sapegin opened 6 years ago

sapegin commented 6 years ago

image 2018-06-22 at 7 37 01 pm

Can we disable links on heading on the main page?

bebraw commented 6 years ago

I have a better solution here. AnchorProvider and AnchorHeader work in pair to solve it. To integrate, it might need the same Markdown solution too.

sapegin commented 6 years ago

I'd probably split book description Markdown files into two and have all heading in React. That would solve the issue for landing pages at least. We don't need these links on landing anyway.

bebraw commented 6 years ago

Ok, splitting sounds fine.

I kind of like having headers behind some component anyway as then we can do auto-anchors and such.

sapegin commented 6 years ago

Yup, if we want to. But I think it's unnecessary on marketing pages.