search

survivejs / webpack-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/webpack/
2.42k stars 319 forks source link

Splitting configuration chapter - two typos #130

Closed jeggett closed 7 years ago

jeggett commented 7 years ago

I can be wrong because I am not an English native-speaker. So take my remarks with a grain of salt.

  1. In the "The Benefits of Composing Configuration" section in second paragraph you wrote:

    Instead of duplicating the same, or at worst similar, configuration

I think you probably mean "duplicating similar, or at worst the same" because duplicating the same thing is worse than duplicating similar things =)

  1. In the "Conclusion" section in first paragraph you wrote:

We'll solve some specific problem through composition and we will expand our vocabulary that way.

Two variants: a) As far as I know with a singular noun, "some" is used to talk of something whose existence is known, but whose nature or identity is not as in "There must be some clue". But why is "specific" goes after "some" then? b) You just missed "s" in "problems"

sapegin commented 7 years ago

(Another non-native here ;–)

I think in the second “specific” means something like “unusual”. Not sure it‘s the best word here though.

bebraw commented 7 years ago

Thanks! Rephrased. 👍