survivejs / webpack-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/webpack/
2.42k stars 319 forks source link

React chapter has invalid configuration #147

Closed shepmaster closed 7 years ago

shepmaster commented 7 years ago

This snippet:

const common = {
  ...
  plugins: {
    new HtmlWebpackPlugin({
      template: HtmlWebpackTemplate,
      title: 'Demo app'
      appMountId: 'app', // Generate #app where to mount
      mobile: true, // Scale page on mobile
      inject: false, // html-webpack-template requires this to work
    }),
  },
};

A comma is missing after title and the plugins hash is missing a key corresponding to the value for HtmlWebpackPlugin.

shepmaster commented 7 years ago

... and the plugins hash

It should probably be an array, actually.