survivejs / webpack-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/webpack/
2.42k stars 319 forks source link

add missing webpack variable in webpack.config.js #249

Closed adi-zz closed 7 years ago

adi-zz commented 7 years ago

the variable webpack was not declared in the code sample for webpack.config.js from Setting Up CommonsChunkPlugin section

bebraw commented 7 years ago

Thanks. This leads to another tweak later in the chapter but I'll do that.

Let me know your name if you want to the credits. ;)

adi-zz commented 7 years ago

Yes.. I could have anticipated the extra changes in that chapter. As I saw, I think you did the in the meanwhile. My name is Adi, but don't bother regarding the credits, I just fixed some small typos. :)

bebraw commented 7 years ago

Ok, cool. 👍