search

survivejs / webpack-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/webpack/
2.42k stars 319 forks source link

Suggest disabling instead of enabling 'safe write' @ IDE settings #261

Closed dcarral closed 7 years ago

dcarral commented 7 years ago

This change aligns the book with Webpack docs, as seen @ https://webpack.github.io/docs/webpack-dev-server.html#working-with-editors-ides-supporting-safe-write.

However, I'm slightly confused (as a non safe-write user :P). Judging from this commit on January, 30th (which removes a similar warning from a previous section), it seems like the underlying problem has been fixed @ watchpack (concretely, thanks to this commit from September, 2015), and therefore this warning doesn't apply anymore for Webpack 2.

@bebraw Time to get rid of the warning altogether instead of fixing it?

bebraw commented 7 years ago

Yeah, I'll drop the warning since it has been fixed in watchpack. Good call.

Sorry for the delay again!