search

survivejs / webpack-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/webpack/
2.42k stars 319 forks source link

Fix comment regarding 'devServer.overlay' option #262

Closed dcarral closed 7 years ago

dcarral commented 7 years ago

Implemented @ https://github.com/webpack/webpack-dev-server/pull/790, overlay: true captures warnings too.

Source code where both settings are set to the same boolean value can be found @ https://github.com/webpack/webpack-dev-server/blob/master/client/index.js#L81.

@bebraw What do you think, should we tweak the feature behavior @ webpack-dev-server, so it matches this inline comment as well as the intended behavior as per https://github.com/webpack/webpack-dev-server/issues/789, quoting:

overlay: true would be the same as overlay: { errors: true, warnings: false }.

bebraw commented 7 years ago

Thanks!

Sorry for the delay. A bit of travel. 👍