survivejs / webpack-book

From apprentice to master (CC BY-NC-ND)
https://survivejs.com/webpack/
2.42k stars 319 forks source link

Better to mention to disable the autoprefixer of the cssnano #274

Closed shuaibird closed 4 years ago

shuaibird commented 7 years ago

Section: Optimizing - Minifying - Minifying Css By default, the cssnano would remove the vendor prefix of the stylesheet. So I think it better to disable the autoprefixer, or at least inform the reader somewhere in this section.

bebraw commented 7 years ago

Yeah, good point. That should become a warning.

sapegin commented 7 years ago

As I see in the docs it’s disabled by default: http://cssnano.co/guides/optimisations/

By default, the cssnano would remove the vendor prefix of the stylesheet.

This is not correct: it will remove only unnecessary prefixes based on your browserslist, if this option is enabled.

shuaibird commented 7 years ago

@sapegin Nope. Here's my .broswerslistrc file, you could test it by using the flex.

ios >= 8
android > 4.4
and_qq > 9
sapegin commented 7 years ago

Then the cssnano docs are wrong, feel free to send a pull request there ;-)

TiburonzinGT commented 6 years ago

@sapegin Hello, I would like to translate to Spanish but I do not know how. I would like to do it by means of pull request :)

bebraw commented 6 years ago

@shadowz10 I set up a repository for you. You could translate against the master branch. Let me know if you need help syncing the work etc. I can also get it online when you want.

TiburonzinGT commented 6 years ago

@bebraw perfect, I can do the translations using PR?

bebraw commented 6 years ago

@shadowz10 You could write PRs, have someone review, and then merge to master over there, yeah. You could ask @raulexposito how he did it.

TiburonzinGT commented 6 years ago

@bebraw thanks, I'm already working on some translations when you can review them to merge them.

bebraw commented 6 years ago

@shuaibird @sapegin Is this relevant still? Is there something to change here?

bebraw commented 4 years ago

Let's close.