survivingwithandroid / WeatherLib

Android Weather Library: android weather lib to develop weather based app fast and easily
http://survivingwithandroid.github.io/WeatherLib/
640 stars 170 forks source link

Weather.Temperature vs DayForecast.ForecastTemp #13

Open johnuopini opened 10 years ago

johnuopini commented 10 years ago

Weather.Temperature Max/Min are "forecast" data (since the only "current" information is the "current" temperature") so i am not sure why DayForecast.ForecastTemp exists. In my opinion it should be removed completely and only "Weather.Temperature" should be used.

This would also correct the issue in the Yahoo implementation since there the first day of Forecast is the day after (day 1) while in OpenWeatherMap the first day of forecast is the current day. It should be the current day in both and Min&Max should be set on forecast only.