survivingwithandroid / WeatherLib

Android Weather Library: android weather lib to develop weather based app fast and easily
http://survivingwithandroid.github.io/WeatherLib/
640 stars 170 forks source link

All Weather Data and some problems and Improvement ! #22

Open aryadegari opened 9 years ago

aryadegari commented 9 years ago

There is no method for fetching all weather data in just one query! I wonder the timezone offset wasn't in data objects ! ("local_tz_offset" in WU conditions data) astronomy data is integrated to location that may cause ambiguity, because it must have it's own method for requesting data. there is no comfortable way to change URLs and their formats (ex: change url to cache server) I think for Wunderground json in hourly data "condition" field misspelled ! (was "conditions" and must be "condition") maybe it's very better to cache data with local database or just with Gson in preferences. Thanks !

survivingwithandroid commented 9 years ago

Thx for your support. Your information are very interesting. I was wondering "I think for Wunderground json in hourly data "condition" field misspelled ! (was "conditions" and must be "condition")" what means

aryadegari commented 9 years ago

here : https://github.com/survivingwithandroid/WeatherLib/blob/master/lib/src/main/java/com/survivingwithandroid/weather/lib/provider/wunderground/WeatherUndergroundProvider.java line 295 : hourForecast.weather.currentCondition.setDescr(jHour.getString("conditions")); must be hourForecast.weather.currentCondition.setDescr(jHour.getString("condition")); please check other keys in json responses from providers.