survivingwithandroid / WeatherLib

Android Weather Library: android weather lib to develop weather based app fast and easily
http://survivingwithandroid.github.io/WeatherLib/
640 stars 170 forks source link

Fix NumberFormatException and refactor YahooWeatherProvider #40

Open m-rm opened 9 years ago

m-rm commented 9 years ago

Hi, basically each commit describes what has been done. I only want to describe "Unify parsing of current weather and forecast" a bit:

Parsing of current and forecast weather was done in similar ways, with a lot of redundant code in both methods. I created a single method to parse it and choose afterwards if current or forecast weather is needed. This has some nice side effects:

survivingwithandroid commented 9 years ago

Hi, thx for your support, Weatherlib needs a code riview and refactoring to improve it. I will check your pull request and add it into the main branch.

m-rm commented 8 years ago

I added a new commit which implements the recent API changes from Yahoo.