search

suryakencana007 / comic-vine-scraper

Automatically exported from code.google.com/p/comic-vine-scraper
0 stars 0 forks source link

Bad object handling when CVDB is deleted #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
DESCRIBE THE PROBLEM:
Re-scraped an issue with a CVDB that seems to have been deleted.  Script 
crashed.  Should probably do some object checking and if the object doesn't 
exist, prompt for re-searching (or at least warn object doesn't exist)

WHAT STEPS WILL REPRODUCE THIS PROBLEM? (Please include the exact name of
the eComic book that you were trying to scrape, if possible.)
1. Scrape a book with CVDB168663 (Action Comics 1000000, does not exist 
anymore)

WHAT VERSION OF COMICVINESCRAPER ARE YOU USING?
1.0.14

PLEASE PROVIDE ANY ADDITIONAL INFORMATION THAT MAY BE OF USE
error log:
scraping next eComic book: Action Comics, #1000000
found CVDB tag in book, scraping details directly: 168663

RETRYING the query...
------------------- PYTHON ERROR ------------------------
Caught Exception: comicvine ERROR: 101 (Object Not Found) for 
http://api.comicvine.com/issue/168663/?
api_key=4192f8503ea33364a23035827f40d415d5dc5d18&format=xml
Traceback (most recent call last):
  File "E:\ComicRack\Data\Scripts\Comic Vine Scraper\ComicVineScraper.py", 
line 92, in main
  File "E:\ComicRack\Data\Scripts\Comic Vine Scraper\ComicVineScraper.py", 
line 175, in _scrape
  File "E:\ComicRack\Data\Scripts\Comic Vine Scraper\comicvinedb.py", line 
102, in query_issue_details
  File "E:\ComicRack\Data\Scripts\Comic Vine Scraper\comicvinedb.py", line 
188, in _get_dom
  File "E:\ComicRack\Data\Scripts\Comic Vine Scraper\comicvinedb.py", line 
177, in _get_dom

Original issue reported on code.google.com by bmen...@gmail.com on 5 Mar 2010 at 10:08

GoogleCodeExporter commented 9 years ago 
Yes, this is a duplicate of issue 44, though I never considered the possibility 
of an
issue being removed from CV.   (You can get the same effect if you just change 
your
CVDB tag to something that doesn't exist, i.e. edit it by hand.)

I'll close issue 44 and keep this one open, since your bug report has more 
details.

Original comment by cban...@gmail.com on 5 Mar 2010 at 10:21

GoogleCodeExporter commented 9 years ago 
Issue 44 has been merged into this issue.

Original comment by cban...@gmail.com on 5 Mar 2010 at 10:21

GoogleCodeExporter commented 9 years ago 
I believe they clean up duplicate issues from time to time, so, theoretically, 
the 
better we get at identifying duplicate issues/volumes, the more the potential 
problem 
will grow :)

Thanks!

Original comment by bmen...@gmail.com on 5 Mar 2010 at 11:31

GoogleCodeExporter commented 9 years ago

Original comment by cban...@gmail.com on 1 Apr 2010 at 5:27

GoogleCodeExporter commented 9 years ago 
Ok, this should be rare, but when it occurs, the script now falls back to the 
normal
behaviour (i.e. a search) that it does when it doesn't have a CVDB tag.

Fixed in 1.0.21

Original comment by cban...@gmail.com on 7 Apr 2010 at 4:31