suryamanohar / tunesremote-plus

Automatically exported from code.google.com/p/tunesremote-plus
0 stars 0 forks source link

Time slider shouldn't be controllable with no active media #92

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Q. What Android hardware device do you own?  (HTC Hero, Samsung Galaxy,
etc)

A: HTC Evo 4G

Q. On what Android operating system version? (2.1, 2.2, Honeycomb 3.0.1
etc)

A: Gingerbread

Q. What DACP server, OS, and version? (OSX iTunes 10.1.2, Windows 7
MonkeyTunes 1.5.1 etc)

A: May 2012 iTunes, Win Xp SP3 32-bit

Q. What TunesRemote+ version? (found on Menu->More->About)

A: latest beta as of 5.31.2012

Please provide any additional information below.

When the app is started in wifi mode, it automatically connects to a known 
media server in my house. The Main Player Activity starts as expected, with no 
media "active", i.e. a black screen with the prev/next/play/pause controls, and 
time slider. The time slider can be manipulated. If you do manipulate it, the 
app will force close. It should probably disabled. There's no song playing, so 
there's nothing to skip to.

Original issue reported on code.google.com by mark.fre...@gmail.com on 1 Jun 2012 at 12:38

GoogleCodeExporter commented 8 years ago

Original comment by mellowaredev on 1 Jun 2012 at 2:49

GoogleCodeExporter commented 8 years ago
Thanks I'll work on this after exams. I think what I'll probably do is have a 
view over the screen which blocks any UI interaction whilst its connecting (and 
disable the slider until there's music playing)

Original comment by aml.cur...@gmail.com on 1 Jun 2012 at 6:39

GoogleCodeExporter commented 8 years ago
Can't you bind the Enabled property to something that determines if there is 
audio playing. You are the dev, but just seems klunky to add a transparent 
Activity like that. Or, perhaps handle the slider change event differently. 

Original comment by mark.fre...@gmail.com on 1 Jun 2012 at 6:43

GoogleCodeExporter commented 8 years ago
Yeah I think essentially the slider must be expecting something and is throwing 
a NullPointerException.  We should probably just prevent it at the Slider 
because you may want to be able to press the Play button to start a song on the 
server.

Original comment by mellowaredev on 1 Jun 2012 at 7:14

GoogleCodeExporter commented 8 years ago
Yeah sorry - I was talking about having the overlay screen until its connected 
to a library (because that can sometimes take a while) as a separate thing - if 
that sounds like a good idea

Original comment by aml.cur...@gmail.com on 1 Jun 2012 at 7:44

GoogleCodeExporter commented 8 years ago
Oh yeah that is a good idea.

Original comment by mellowaredev on 1 Jun 2012 at 7:49

GoogleCodeExporter commented 8 years ago
OK I posted a BETA in the Downloads area that I think fixes this.  Basically 
needed to check for session == null like all the other controls were doing.  I 
hope this fixes this issue!  Let me know.

Original comment by mellowaredev on 4 Jun 2012 at 12:12

GoogleCodeExporter commented 8 years ago
How do I reproduce this, to test it?

Original comment by cramermaurice@gmail.com on 12 Jun 2012 at 8:59

GoogleCodeExporter commented 8 years ago
I think this is more of an iTunes thing but I think you can do it MonkeyTunes 
as well.

1. Stop TunesREmote, and in MM clear your entire Now Playing Cue so nothing is 
in it.

2. Restart MM so it shows up with no song playing and nothing in Now Playing.

3. Now Start TunesREmote it should connect to your library but the screen 
should be black since no song is playing, try and move the slider.

Original comment by mellowaredev on 12 Jun 2012 at 10:25

GoogleCodeExporter commented 8 years ago
Yup works just fine as you described in your fix. So issue can be closed.

Original comment by cramermaurice@gmail.com on 14 Jun 2012 at 6:56

GoogleCodeExporter commented 8 years ago
2.5.0 Released to Android Market

Original comment by mellowaredev on 4 Jul 2012 at 2:36