Feature - shadow options

kvtemadden commented 1 month ago

Pull Request Template

Description

Provides the user with more options/control over image shadows.

Related Issue

18

Closes #18

Changes Made

Used roundRect for shadow to provide filled shadow
Implemented shadow to match image shape if borderRadius is not set
Added popover component and created shadowManager to display options on UI

Type of Change

Select the type of change made with this pull request:

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Screenshots (if applicable)

Screen Recording 2024-09-30 at 12 43 08

How Has This Been Tested?

Manually tested on local environment

Checklist

Check off the following items before submitting the pull request:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mockly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 1, 2024 9:23am

suryanshsingh2001 commented 1 month ago

@kvtemadden Hey, please take a pull for the latest changes from master branch. And add these changes after it.

kvtemadden commented 1 month ago

Hey @suryanshsingh2001, just merged main into this branch & resolved conflicts.

And add these changes after it

Was there something you wanted me to update?

suryanshsingh2001 commented 1 month ago

Hey @suryanshsingh2001, just merged main into this branch & resolved conflicts.

And add these changes after it

Was there something you wanted me to update?

No, just the contents of this pull request.

suryanshsingh2001 commented 1 month ago

Hi @kvtemadden,

I’m experiencing a potential memory leak or performance issue with the browser, as the RAM usage is abnormally high. I’ve captured a screen recording that illustrates the problem in preview mode for vercel.

Please take a look for any potential memory leaks or performance overhead. I have tested in the latest version so far no issues. Let me know if you are able to find any issues.

https://github.com/user-attachments/assets/ff25a5ed-aa30-4c1d-81b7-8b1804304f4a

kvtemadden commented 1 month ago

Hey @suryanshsingh2001, I think this might've been to do with how the image save, use and paint to canvas was working since fixing the canvas flickering.

I've gone through and tweaked a few parts to make it more reliable, I can't repro the issue but could you give it another go please?

suryanshsingh2001 commented 1 month ago

Hi @kvtemadden,

It seems the issue isn't occurring anymore. I suspect it might have been a bug with the Vercel preview environment, as I wasn't able to reproduce it in my local setup. It looks like the issue appeared unexpectedly and has since resolved itself.

suryanshsingh2001 commented 1 month ago

Hi @kvtemadden,

I wanted to take a moment to personally thank you for your valuable contributions. Your insights and solutions have truly shaped the way Mockly has progressed, and I’m incredibly grateful for your work.

If there are any other issues you’d like to explore or areas for further improvement, feel free to dive in. I’d love the opportunity to collaborate with you again in the future.

Thanks once again, and I look forward to working with you soon!

suryanshsingh2001 / mockly