Closed 0xkafkaa closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
mockly | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 24, 2024 11:10am |
@0xkafkaa Hey, good job with download options. Here are some changes needed before we complete the PR. The dropdown position and appearance looks odd, to fix this, you can either:
@suryanshsingh2001 sure, will work and update
Hey @suryanshsingh2001,
Added the dropdown component as discussed.
Regards, 0xkafkaa.
Hey @0xkafkaam, there were some overflow issues on side menu. I have fixed that issue, you can now add the dropdown component. Take a pull from master
branch and add new changes.
hey @suryanshsingh2001, let me know if its ok.
Hey @0xkafkaa, great job on this!
The handleDownload
function is quite lengthy and could benefit from being refactored into the lib
file for better maintainability. You can create another PR to handle this refactoring if you'd like!
Ok @suryanshsingh2001 . will look into it.
Added options for download. Implemented jpg/png/svg/pdf for download options. Used jspdf for downloading PDFs.
Let me know your comments.
Regards, 0xkafkaa.