xul889
commented
2 years ago closed wrong place posted for peer review
Closed xul889 closed 2 years ago
xul889
commented
2 years ago closed wrong place posted for peer review
What is the Github URL of the project you are reviewing? https://github.com/luannebe/e15/tree/main/p2
What is the production URL of the project you are reviewing? http://e15p2.flyingdog.nu
Are you able to produce any errors or unexpected results when using the site? NO.
Is their appropriate separation of concerns amongst controllers and views? E.g. is there any non-display specific logic in views, or display-specific code in controllers? No
Are there any parts of the code that you found interesting or taught you something new? TailWind CSS is used which is inspiring for my next project. It is powerful and easy to use.
Are there any parts of the code that you don't understand? No.
Are there any parts of the code that you feel could be written in a more efficient or clearer manner? In welcome.blade.php, from line 62 to 89, there might be a way to loop the style to make it cleaner.
Are there aspects of the code that you feel were not self-evident and would benefit from comments? No. Code is clear and easy to understand.
Are there any best practices discussed in course material that you feel were not addressed in the code? No. I love this project.
Do you have any additional comments not covered in the above questions? Yes. The layout before a user click the button should look more in the center. Right now, it is left aligned. I would make the coins show in the below, if I were him, then align all the items in the center. In that case, the layout will be consistent.