Open susannaelsie opened 7 years ago
Hello Susanna,
I appreciate your efforts in hw02 and it is really a good homework (check plus). Below are my comments.
General Issues (check plus) Pros
Cons Not found yet. I don't think there is any con in this part.
Report Process (check plus) Pros
Cons I really cannot find any cons.
Main Part of the Homework (check plus) Pro
Cons (Suggestions)
(q1 <- ggplot(gapminder, aes(x = continent)) +
geom_histogram(stat="count") +
labs(x="Continent", y="Counts"))
Yuanji
Smell test of data: Yes, see comments re typeof()
Explores at least one categorical/quantitative variable: Yes
Uses various ggplot types: Yes (scatterplot, bar plot, density plot, boxplot)
Uses filter()
, select()
, and %>%
: Yes
Bonus (evaluate code, tables, more dplyr): Partial (attempt code evaluation)
Reflection on process: Yes
Comments:
typeof()
produces odd results with factors – it's calling $country
and $continent
integers because they are stored as integers under the hood, but it's important to be able to distinguish that from actual numeric data like $lifeExp
. The 'class()' function will tell you when something is a factor.p
several times in such a way that it's unclear what p
actually contains and what changes you're making. For example, why are you transforming a plot of life expectancy over time to use a log scale (p + geom_point() + scale_x_log10() # transforms the scatterplot to log scale
)?# altered figure width so we could see the lines better
: cool, but how? The code not in the chunk I'm seeing.Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.
@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho
Link to hw02 folder Link to hw02.md file Latest commit