search

suse-edge / charts

SUSE Edge engineering Helm charts
https://suse-edge.github.io/charts/
Apache License 2.0
5 stars 18 forks source link

Shall we use Neuvector 5.3.0? #109

Open e-minguez opened 5 months ago

e-minguez commented 5 months ago

https://github.com/suse-edge/charts/blob/48dcba2d5ba553b8d23ee21384558de325f15e4d/charts/neuvector-core/2.6.6/values.yaml#L8

e-minguez commented 5 months ago

Also a diff from the original one https://github.com/neuvector/neuvector-helm/blob/master/charts/core/values.yaml with the one here just bring these changes:

controller:
  replicas: 1
  ranchersso:
    enabled: true
manager:
  enabled: false
cve:
  scanner:
    enabled: false
    replicas: 1
k3s:
  enabled: true
crdwebhook:
  enabled: false

Shall we just minify ours and refer to the original one for more elaborated changes?

hardys commented 4 months ago

Thanks for raising this @e-minguez - my understanding from discussion with @agracey is that we may want to consider removing the suse-edge neuvector chart, as you mention the changes are only to the values, so we can document those instead of maintaining a wrapper chart.

e-minguez commented 4 months ago

I can send a PR to drop the charts here and instead add a README on how to deploy it using the official one. Is that right @hardys @agracey ?