Closed manuelbuil closed 3 months ago
LGTM but I think you skipped the index.html generation :)
LGTM but I think you skipped the index.html generation :)
I thought I had run make index
, was there another step? Let me RTFM! I wish all chart repos were working in the same way :P
BTW, there was something not really working with the sriov-crd depenceny but I found the reason.
(nit) wondering if we might also want to add these annotations too?
catalog.cattle.io/certified: rancher catalog.cattle.io/kube-version: '>= 1.16.0-0'
The one about kube-version is so trivial that I decided not to add it. And the "certified: rancher", if I understood correctly, has to be added on the charts that are present in the rancher/charts. For the rest I don't know, so I did not add it
This PR makes the chart more "Rancher manager" friendly for users that would start using this repo in v2.9 to consume sriov.
Changes:
Applying these changes makes it look and feel better:![image](https://github.com/suse-edge/charts/assets/16151814/00976d3d-5df0-4e56-9ca5-bd8a62b40611)
Compared to:![image](https://github.com/suse-edge/charts/assets/16151814/be02b651-ad33-4cda-babc-c160b3ccfb19)