search

suse-edge / charts

SUSE Edge engineering Helm charts
https://suse-edge.github.io/charts/
Apache License 2.0
7 stars 20 forks source link

Update SR-IOV to `v1.3.0` #145

Closed mgfritch closed 3 months ago

mgfritch commented 3 months ago

Updates to the latest sriov and nfd chart releases:

This also modifies the chart version scheme to use the upstream chart's semver instead of the prior scheme (<version>+up<upstream_version>). For example, the prior chart version was 1.2.4+up0.1.0 whereas the next published chart version will be 1.3.0

Open vSwitch networks are currently unsupported. The OvsNetwork CRD has been added, but any reference to the ovs-cni image has been removed.

mchiappero commented 3 months ago

I think it LGTM, but out of curiosity, for my own understanding: do we need to adds the OvsNetorks CRD anyway?

mgfritch commented 3 months ago

Yes, it's needed because the sriov-network-operator will attempt to index the OVSNetwork and fail during start-up if the api-resource is not present:

unable to create index field for cache  {"error": "no matches for kind \"OVSNetwork\" in version \"sriovnetwork.openshift.io/v1\""}

See also: https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/e1f5b74b1cdfe35484e1f2bb241969fbca0769d0/main.go#L166-L173

mchiappero commented 3 months ago

Yes, it's needed because the sriov-network-operator will attempt to index the OVSNetwork and fail during start-up if the api-resource is not present:

Thank you for the explanation! I'll approve once we address the other comment.