search

suse-edge / charts

SUSE Edge engineering Helm charts
https://suse-edge.github.io/charts/
Apache License 2.0
7 stars 20 forks source link

Release Metal3 0.4.1 #74

Closed Kristian-ZH closed 11 months ago

Kristian-ZH commented 11 months ago

Release Metal3 0.4.1

This release contains all the changes from 0.4.0 plus the updated security context from 0.2.1

Kristian-ZH commented 11 months ago

A review from @ipetrov117 is required for merging this PR

hardys commented 11 months ago

lgtm but will defer to @ipetrov117 for review/merge

As mentioned in #69 it's quite hard to review these changes as a single commit (I had to do a local recursive diff) - we should think about how to handle that, for example by using PRs with two or more commits, where the first commit is the copy of the existing chart, then subsequent commits with changes can be more easily reviewed?

Kristian-ZH commented 11 months ago

for example by using PRs with two or more commits, where the first commit is the copy of the existing chart, then subsequent commits with changes can be more easily reviewed?

That's a good idea +1

Kristian-ZH commented 11 months ago

As mentioned in https://github.com/suse-edge/charts/pull/69 it's quite hard to review these changes as a single commit

The review should be a bit easier for this PR because the actual changes are in the packages dir. The issue comes when we need to change a previous version that is not referred by the packages (packages contains the chart from the latest version)

hardys commented 11 months ago

@hardys, do we have any other changes that are on the roadmap before pushing the new version to Sylva. I think these are the last ones, correct?

I think we can land this and update the version in Sylva - there are more changes I'd like to see but those can wait for a future version 👍

ipetrov117 commented 11 months ago

I think we can land this and update the version in Sylva - there are more changes I'd like to see but those can wait for a future version 👍

Okay, I will open a PR on Sylva's side shortly.