search

suse-edge / charts

SUSE Edge engineering Helm charts
https://suse-edge.github.io/charts/
Apache License 2.0
7 stars 20 forks source link

Fix Metal3 Basic auth issue #77

Closed Kristian-ZH closed 10 months ago

Kristian-ZH commented 10 months ago

This PR fixes and issue with the Metal3 Basic auth, where on each upgrade the basic auth secret will re-encode the previous username and password which will cause changes in the secret data

closes https://github.com/suse-edge/charts/issues/76

ipetrov117 commented 10 months ago

Could we have the move of the standard 0.4.1 -> 0.4.2 artefacts in one commit and the actual fix in another, as it is hard to detect the new changes here?

Kristian-ZH commented 10 months ago 
Could we have the move of the standard 0.4.1 -> 0.4.2 artefacts in one commit and the actual fix in another, as it is hard to detect the new changes here?

The new changes are in the packages directory

hardys commented 10 months ago

Could we have the move of the standard 0.4.1 -> 0.4.2 artefacts in one commit and the actual fix in another, as it is hard to detect the new changes here?

Agreed - not blocking this PR on it, but I think an approach like on my branch may be a good idea in future - particularly if there are multiple changes then we can have a series of commits followed by a "make charts" commit