search

suse-edge / charts

SUSE Edge engineering Helm charts
https://suse-edge.github.io/charts/
Apache License 2.0
5 stars 18 forks source link

[RFE] Add "app.kubernetes.io/component" labels to metal3 components #91

Closed e-minguez closed 5 months ago

e-minguez commented 6 months ago

currently the labels are:

NAME                                                    READY   STATUS    RESTARTS   AGE     LABELS
baremetal-operator-controller-manager-85756794b-ggr8k   2/2     Running   0          4m38s   control-plane=controller-manager,pod-template-hash=85756794b,webhook=metal3-io-v1alpha1-baremetalhost
metal3-metal3-ironic-5757bc78b8-q9fgg                   1/4     Running   0          4m38s   app.kubernetes.io/instance=metal3,app.kubernetes.io/name=metal3-ironic,pod-template-hash=5757bc78b8
metal3-metal3-mariadb-5b5dc5c6d9-gzxv4                  1/1     Running   0          4m38s   app.kubernetes.io/instance=metal3,app.kubernetes.io/name=metal3-mariadb,pod-template-hash=5b5dc5c6d9

(also ironic and mariadb share the same app.kubernetes.io/instance one)

Other components such as metallb or certmanager use it as:

NAME                                  READY   STATUS      RESTARTS   AGE     LABELS
helm-install-metallb-6dj46            0/1     Completed   0          3d21h   batch.kubernetes.io/controller-uid=38e17990-4115-43af-85cd-f26e02c028bc,batch.kubernetes.io/job-name=helm-install-metallb,controller-uid=38e17990-4115-43af-85cd-f26e02c028bc,helmcharts.helm.cattle.io/chart=metallb,job-name=helm-install-metallb
metallb-controller-7cbd6cf47d-pm582   1/1     Running     0          3d21h   app.kubernetes.io/component=controller,app.kubernetes.io/instance=metallb,app.kubernetes.io/name=metallb,pod-template-hash=7cbd6cf47d
metallb-speaker-mw4mz                 4/4     Running     0          3d21h   app.kubernetes.io/component=speaker,app.kubernetes.io/instance=metallb,app.kubernetes.io/name=metallb,controller-revision-hash=87678d87,pod-template-generation=1
metallb-speaker-p84jt                 4/4     Running     0          3d21h   app.kubernetes.io/component=speaker,app.kubernetes.io/instance=metallb,app.kubernetes.io/name=metallb,controller-revision-hash=87678d87,pod-template-generation=1
metallb-speaker-x7t96                 4/4     Running     0          3d21h   app.kubernetes.io/component=speaker,app.kubernetes.io/instance=metallb,app.kubernetes.io/name=metallb,controller-revision-hash=87678d87,pod-template-generation=1

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels