search

suse-edge / edge-image-builder

Tool for creating and configuring a set of images to automate the deployment of Edge environments
Apache License 2.0
33 stars 20 forks source link

Revisit how to trigger combustion for raw SLE Micro images #57

Open jdob opened 7 months ago

jdob commented 7 months ago

Combustion only checks volumes of certain names for the /combustion directory. The SLE Micro raw image sets the root partition name to ROOT, which isn't one of the checked volume names.

The current implementation changes the label to INSTALL (the same as the ISO installer uses) so it's picked up when combustion runs. That feels a bit dirty and a better solution should be researched when we have time.

jdob commented 7 months ago

I spoke with Fabian Vogt about the possibility of adding ROOT as one of the volume labels combustion checks for. Here is his response:

Hi! I don't really like using ROOT for multiple reasons: The root FS is btrfs and the default subvolume will be mounted by combustion, which is the currently active root FS snapshot. This can be surprising behaviour. This also means that the /combustion directory is part of the system snapshots and always visible in the running system as /combustion. Using the EFI system partition is an option, but that shares the second downside: It's visible at /boot/efi/combustion/.... This part could be worked around by deleting the directory from inside the combustion script at least. The other advantage of using the ESP is that it's a filesystem also natively supported by other OSs, so it can be written to more easily.

I haven't done anything further based on his response.