search

sushiswap / shoyu

Shoyu contracts
https://shoyunft.com
MIT License
168 stars 126 forks source link

Implement EIP2981 for royalties #5

Closed blmalone closed 3 years ago

blmalone commented 3 years ago

I've noticed you've got a royalty implementation for erc721 and erc1155. https://github.com/sushiswap/shoyu/blob/bdc4863d9ce07dbf670bcf0a6327663dad9aee2a/contracts/interfaces/IBaseExchange.sol#L23

Have you considered this finalized EIP for communicating royalty information? https://eips.ethereum.org/EIPS/eip-2981

levx-me commented 3 years ago

That's actually a good idea

blmalone commented 3 years ago

@levx-io

Cool, I'm a contributor to the standard so let me know if you need any help. I think it would be a great addition to this project.

levx-me commented 3 years ago

Which other projects are adopting it?

blmalone commented 3 years ago

It just got finalized last week.

https://github.com/manifoldxyz/royalty-registry-solidity/ is using it and currently in talks with NFT exchanges :)

It's a win win situation anyway. You're basically doing it already, just tweak it for a common format.

Over 1 year of back and forth discussions to get to this point for this EIP.

cliffhall commented 3 years ago

Which other projects are adopting it?

I've implemented it in both the new KnownOrigin and Seen.Haus contract suites (both nearing deployment), and spent the last several months in the 2981 discussion as well. Can also provide input if needed.

dievardump commented 3 years ago

I'm also implementing it in every NFT and Exchange contracts I do as a Solidity dev.

Also implemented it on BeyondNFT where possible and plan to implement new Exchange and NFT contracts with its support soon.

I know other developers like the Manifold guys do have that per default in their CreatorCore contracts.

example: https://etherscan.io/address/0x00372812abcb11c2ea291aeb7f612d9e0524b013#code#F21#L1

levx-me commented 3 years ago

Merged #11

blmalone commented 3 years ago

@levx-io nice one!