search

sushiswap / subgraphs

Sushi subgraphs
40 stars 95 forks source link

Feature/sushiswap #37

Closed OlaStenberg closed 2 years ago

OlaStenberg commented 2 years ago

The only thing that's different and needs changing now is this image

Trident only sends amountIn and amountOut, while legacy have 0in 0out, 1in and 1out.. I guess we could figure out which one is in and out by amount or something, then go with trident schema.. Thoughts @matthewlilley?

OlaStenberg commented 2 years ago

Should probably prefix CPP in trident.. Or we could do it whenever we add more pool types, would need to resync either way

matthewlilley commented 2 years ago

The only thing that's different and needs changing now is this image

Trident only sends amountIn and amountOut, while legacy have 0in 0out, 1in and 1out.. I guess we could figure out which one is in and out by amount or something, then go with trident schema.. Thoughts @matthewlilley?

Yeah, I think this changed because previously the UI would have to figure out which direction the tokens are going in & out, which I remember being super annoying.

OlaStenberg commented 2 years ago

Yeah, I think this changed because previously the UI would have to figure out which direction the tokens are going in & out, which I remember being super annoying.

Yup, this is better. image

This will be display values most of the time, right? like the usage here: image Keep it as BigDecimal? @matthewlilley

matthewlilley commented 2 years ago

Yeah, I think this changed because previously the UI would have to figure out which direction the tokens are going in & out, which I remember being super annoying.

Yup, this is better. image

This will be display values most of the time, right? like the usage here: image Keep it as BigDecimal? @matthewlilley

Roger