sushiswap / sushiswap-interface

🍣 An open source interface for the SushiSwap Protocol
https://app.sushi.com
374 stars 704 forks source link

Rotating, Swipeable Announcements Banner #118

Closed omakasebar closed 3 years ago

omakasebar commented 3 years ago

Operational Preface:

Open a new branch when ready for review open a PR against Canary. Branch should be titled announcements_banner and mention this issue

The existing implementation can be found here: https://github.com/sushiswap/sushiswap-interface/blob/master/src/pages/Swap/index.tsx#L606

Sample Design Page:

banner

Currently there is only one announcement in the swap section. In order to allow for announcements the following enhancements should be made:

omakasebar commented 3 years ago

@msilucifer if you could provide an update to this issue that would be appreciated! Thanks

chillichelli commented 3 years ago

Wouldn't it make sense to fetch the banners from some CMS? In figma we can just extract banners with text as an image right?

omakasebar commented 3 years ago

Hmm CMS would be cool - but we could just have it as static json/image. Which CMS should we use?

chillichelli commented 3 years ago

Yea that could also work. I don't really have much experience with CMS's but any headless cms would suffice

msilucifer commented 3 years ago

I am working on this issue now.

Aveesh52-zz commented 3 years ago

Can I work on this issue?

omakasebar commented 3 years ago

@msilucifer mind giving an update? Or will reassign to @Aveesh52

msilucifer commented 3 years ago

No, I am working on this issue. I sent some DMs to you.

omakasebar commented 3 years ago

Please provide related updates in the issue. Thanks!

msilucifer commented 3 years ago

Okay