Closed omakasebar closed 3 years ago
@msilucifer if you could provide an update to this issue that would be appreciated! Thanks
Wouldn't it make sense to fetch the banners from some CMS? In figma we can just extract banners with text as an image right?
Hmm CMS would be cool - but we could just have it as static json/image. Which CMS should we use?
Yea that could also work. I don't really have much experience with CMS's but any headless cms would suffice
I am working on this issue now.
Can I work on this issue?
@msilucifer mind giving an update? Or will reassign to @Aveesh52
No, I am working on this issue. I sent some DMs to you.
Please provide related updates in the issue. Thanks!
Okay
Operational Preface:
Open a new branch when ready for review open a PR against Canary. Branch should be titled announcements_banner and mention this issue
The existing implementation can be found here: https://github.com/sushiswap/sushiswap-interface/blob/master/src/pages/Swap/index.tsx#L606
Sample Design Page:
Currently there is only one announcement in the swap section. In order to allow for announcements the following enhancements should be made: