sushiswap / trident

Rapid AMM Development Framework
GNU General Public License v3.0
231 stars 126 forks source link

V2 migrator #320

Closed sarangparikh22 closed 2 years ago

gasperbr commented 2 years ago

I don't see why this is needed. Trident CP supports unequal liquidity addition and we should use that feature. And it's desirable to migrate 100% of liquidity instead of receiving dust in return. We can also assume the prices of pools will (roughly) match. Alternatively, we can add a different parameter of how much the prices are allowed to differ - this can replace the rest of the slippage params and would even be more efficient. But I think the current slippage params are sufficient as they prevent any possible exploit.