sushj / ebookdroid

Automatically exported from code.google.com/p/ebookdroid
0 stars 0 forks source link

Thinnest annotation line is too thick #568

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Select hand-drawing annotation tool
2. Select thinnest line from drop-down menu
3.

What is the expected output?
Expect a line as thin as I get in Acrobat Reader or iAnnotate

What do you see instead?
a line that is much thicker

What version of the product are you using?
Android version 2.0.1

On what operating system? Android 4.2.2

What device are you using? Samsung Galaxy Tab 10.1

Please provide any additional information below.

Original issue reported on code.google.com by rhco...@lbl.gov on 31 Jul 2013 at 6:30

GoogleCodeExporter commented 8 years ago
I agree. The lines should be somewhat thinner.
See attached file. 
One of the problems is that it isn't clear how big the text displayed on screen 
will be, so it isn't clear how thin
to make the lines. (In this case, an A5 page was displayed) Best make it 
settable.

Original comment by mlachm...@gmail.com on 6 Aug 2013 at 1:42

Attachments:

GoogleCodeExporter commented 8 years ago
Hmmm... It seems that there is some bug somewhere - we are trying to choose 
line width based on screen DPI, so on all devices it should be the same. Can it 
be that in your device DPI specified in system (/system/build.prop parameter 
ro.lcd.density) does not match real screen DPI?

Original comment by Andrei.K...@gmail.com on 6 Aug 2013 at 2:21

GoogleCodeExporter commented 8 years ago
Yes it is exactly like my screen: 320 
Though it is called ro.sf.lcd.density

But why would it depend on the screen density, and not on the book? I think it 
should approximately
the width of a dot in the text.

Original comment by mlachm...@gmail.com on 6 Aug 2013 at 2:42

GoogleCodeExporter commented 8 years ago
Since I posted the issue originally I thought I should offer my data here.
My ro.sf.lcd_density is 160.  This is apparently generated by buildinfo.sh,
so nothing I have control over.  This is a Samsung Galaxy Tab 10.1; I have
no idea if this is an appropriate density for the device.

But I can say that when I posted I was talking about annotating a pdf file,
as opposed to an ebook in one of the other supported formats; the thinnest
annotation is way thicker than a pixel, about 1/16th inch.  Certainly way
thicker than a dot.

Original comment by rhco...@lbl.gov on 6 Aug 2013 at 4:08

GoogleCodeExporter commented 8 years ago
Ok. I think all that dpi thing not working. I think we should add setting of 
base line width witn value for example 10 for current width, so anyone can do 
it ten times thinner.

Original comment by Andrei.K...@gmail.com on 6 Aug 2013 at 7:30

GoogleCodeExporter commented 8 years ago
Sounds like a good plan.  Though maybe a step of 10x is too much, maybe 5x or 
more steps.

Original comment by rhco...@lbl.gov on 6 Aug 2013 at 7:53

GoogleCodeExporter commented 8 years ago
I have been downloading every update hoping for a fix to the annotation line 
width issue.  Any plans/timeline to address it?  As it is I wind up having to 
annotate in acrobat reader.

Original comment by rhcoh...@gmail.com on 28 Dec 2013 at 8:43

GoogleCodeExporter commented 8 years ago
Please fix this issue. It can't be so hard... at least to hack it to work 
right...
Just add a some additional thicknesses.

Thanks a lot!!

Original comment by mlachm...@gmail.com on 25 Feb 2014 at 11:17

GoogleCodeExporter commented 8 years ago
Желательна также возможность,включаемая в 
окне открытой книги(или настройках) или 
постоянная, сохранения всех аннотаций(или 
хотя бы рукописных) в файле самой книги 
PDF,DJVU(то есть изменения файла книги).Не 
существует ли уже эта возможность в 
платной версии программы?

Original comment by mfnva...@gmail.com on 6 Aug 2014 at 2:14

GoogleCodeExporter commented 8 years ago
> Не существует ли уже эта возможность в 
платной версии программы?

нет и не будет в обоих версиях

Original comment by Alexander.V.Kasatkin@gmail.com on 6 Aug 2014 at 2:37