search

susielu / d3-annotation

Use d3-annotation with built-in annotation types, or extend it to make custom annotations. It is made for d3-v4 in SVG.
http://d3-annotation.susielu.com/
Apache License 2.0
751 stars 68 forks source link

Updates dependencies to latest minor release #53

Closed manuelroth closed 5 years ago

manuelroth commented 5 years ago

Hi @susielu, This PR updates all the dependencies to the latest minor release and adds the ^ to specify that minor release updates should be accepted. I did run the tests locally and they were all green. Please let me know if other files need to be added for this change.

Kind regards, Manuel

susielu commented 5 years ago

Hi Manuel, is there a specific feature in the latest versions that you're interested in using with d3-annotation?

manuelroth commented 5 years ago

There is a problem in d3-drag (before v1.2.0) with non-passive event listeners in Chrome mobile test mode. See this issue for more context. This issue makes dragging the annotations around very sluggish. Upgrading to v1.2.3 would fix that

Bildschirmfoto 2019-03-24 um 17 01 50

susielu commented 5 years ago

@manuelroth thanks for explaining your use case some more. I upgraded the d3-drag library to a version to 1.2.3 but kept the versions specific and downgraded some of the other versions you changed. This is now published with the upgrade as v2.4.0.

I like to keep the dependencies as stable as possible to reduce the possibility of unwanted mistakes or issues arising simply due to version bumps that I am unaware of so I tend to steer clear of the ^ when possible.

manuelroth commented 5 years ago

I understand. Thank you very much for creating a release

manuelroth commented 5 years ago

@susielu after the release of v2.4.0 I am getting this error. As I understand it, it has to do with declaring multiple versions of d3-selection (v1.0.6 and v1.4.0) in yarn.lock. Could it be that you have to run yarn install and update the bundle again?

I am very thankful for any ideas as dragging around annotations in edit mode is not possible anymore in v2.4.0.

susielu commented 5 years ago

Thanks for digging into this, taking a look now.

susielu commented 5 years ago

I published a version v2.5.0 that upgrades to d3-selection@1.4.0 so there are no duplicate versions anymore. Let me know if you still see this issue.

manuelroth commented 5 years ago

Thank you very much. The issues is resolved 🎉