search

susielu / react-annotation

Use react-annotation with built-in annotation types, or extend it to make custom annotations. It is made for annotations in SVG.
http://react-annotation.susielu.com/
Apache License 2.0
396 stars 34 forks source link

TypeScript support #16

Open martpie opened 6 years ago

martpie commented 6 years ago

Hello 👋

Have you considered adding TypeScript typings to react-annotation? :)

susielu commented 6 years ago

I'm not sure how much work that would be, I don't use TypeScript myself. Some contributors helped me add it to d3-annotation. Would love any help on this front.

martpie commented 6 years ago

Would you accept Pull Requests on this repo, or should I try to add them at Definitely Typed?

susielu commented 6 years ago

A pull request would be great!

On Fri, Sep 14, 2018, 1:16 AM Pierre de la Martinière < notifications@github.com> wrote:

Would you accept Pull Requests on this repo, or should I try to add them at https://github.com/DefinitelyTyped/DefinitelyTyped?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/susielu/react-annotation/issues/16#issuecomment-421269063, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYfbUHx9kN686aL-cU1MpON_t4Nfecoks5ua2XngaJpZM4WmzM8 .