susom / redcap-em-shazam

Shazam External Module
MIT License
18 stars 11 forks source link

Matrix header not hiding and staying hidden over the field below it #37

Open dr01d3r opened 4 years ago

dr01d3r commented 4 years ago

The !important modifier added to the height/width css is causing those attributes to not apply at all in Chrome (not tested in IE/Firefox).

REDCap v10.0.1 Shazam v1.3.8

image

Debugging shows that your selector works, but it's the application of the css that is ignored.

image

Additionally, the optional Matrix Header Text is being ignored; though the solution for that is likely to not specify any if the plan is to Shazam it.

123andy commented 4 years ago

Sorry - but I am not following quite following...

Are you saying that hiding the matrix header is no longer working due to changes in how Chrome parses css and the !important modifier?

dr01d3r commented 4 years ago

Seems it's been an ongoing issue for a while in browsers, not just jQuery.

https://www.w3schools.com/jquery/tryit.asp?filename=tryjquery_css_set_multiple

Using that example, adding !important to either one causes that css to not get applied.

123andy commented 4 years ago

Did you try just removing the !important. Is that a fix? I'm just swamped so if you have any suggestions, let me know and I'll make the changes :-)